Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested structures in string_params_for/2 #224

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

germsvel
Copy link
Collaborator

@germsvel germsvel commented Jun 9, 2017

Add support for .string_params_for/2 to handle nested associations and
nested embeds: has_one, has_many, embeds_one, and embeds_many.

I believe this addresses #222, and #215

Add support for `.string_params_for/2` to handle nested associations and
nested embeds: `has_one`, `has_many`, `embeds_one`, and `embeds_many`.
Copy link

@joshuaclayton joshuaclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sitch
Copy link

sitch commented Jun 12, 2017

One exception that could be worth mentioning here is for %Plug.Upload{} if the intended purpose of string_params_for is for controller testing

@germsvel
Copy link
Collaborator Author

I don't know if we should handle %Plug.Upload{} here explicitly since this is ecto-specific but not necessarily related to phoenix.

@germsvel germsvel merged commit adbcc3b into master Jun 23, 2017
@germsvel germsvel deleted the gv-apply-string-keys-deep branch June 23, 2017 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants